Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 6 months ago

Social Links Profile

Creative-mindset21•30
@Creative-mindset21
A solution to the Social links profile challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)
Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Grace•32,130
    @grace-snow
    Posted 6 months ago

    I'm afraid this is overflowing my screen at the sides and making some common beginner errors we see a lot. Hopefully these points help.

    • Keep the html as simple as possible. Remember this is only a single card component that should sit within the main landmark on the page. That means it's a div or section with img, heading, paragraph, blockquote and list of links inside it. You don't need all the extra divs and sections. All that does is make the styling harder and bring no benefit.
    • the heading is the main heading for the page so I'd expect It to be a h1 in this instance.
    • the image description isn't bringing any benefit so I'd recommend treating it as decorative instead with an empty alt attribute.
    • get into the habit of including a full modern css reset at the start of the styles in every project you do. Look up Andy Bell's modern css reset.
    • the card mustn't have an explicit width. Give it a single max width in rem instead so that it can go narrower when it needs to (like on smaller phones).
    • make sure you're choosing units intentionally. I doubt you really want to use rem for the card padding (unless it was part of a clamp or min function with other units). Using rem means that padding will increase along with the user's text size setting in their browser or device, so you can end up with a very narrow area for the content. Using px for this padding would mean it is a fixed value so that wouldn't happen.
    • similarly, give the body or main a little padding on all sides so the card can't touch the screen edges.
    • there is no need for any media query in this. You can delete that.
    • make sure you're styling the links as you should be and not the list items. It might be fine but looked like the links may be small and not have the hover styles when I read the code.

    Overall the css just looks complicated for what is here. But I think that's because of the extra complexity added in the html. Once the markup is simpler the styles should become simpler too.

  • YOUSSEF-ETTABAA•50
    @YOUSSEF-ETTABAA
    Posted 6 months ago

    This solution is visually appealing with responsive design, semantic HTML, and modern typography using Google Fonts. The hover effect adds interactivity, and the structure is well-organized. However, accessibility could improve with better alt text and contrast, and the CSS could be optimized for simplicity. Overall, it's a solid, functional design with minor areas for enhancement.

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Frontend Mentor for Teams

Frontend Mentor for Teams helps companies and schools onboard and train developers through project-based learning. Our industry-standard projects give developers hands-on experience tackling real coding problems, helping them master their craft.

If you work in a company or are a student in a coding school, feel free to share Frontend Mentor for Teams with your manager or instructor, as they may use it to help with your coding education.

Learn more

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub