Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 12 months ago

social-links-profile

Minerva-xx•60
@Minerva-xx
A solution to the Social links profile challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)
Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • P
    ellekost•220
    @lkoster
    Posted 12 months ago

    Great job on your solution! Here are a few points I noticed:

    Semantic HTML: You used appropriate tags like <main>, <section>, and <ul>, which helps with the structure and readability of your code. However, consider using <h2> instead of <h4> to maintain a proper heading hierarchy.

    Accessibility: The alt text for the avatar image is a good start. You might want to ensure that the color contrast for your links when hovered meets accessibility standards. Adding aria-labels to links can also improve screen reader accessibility.

    Responsiveness: Your layout looks good, but it could benefit from some media queries to handle different screen sizes better. Using relative units like % or rem for widths and heights can also improve flexibility.

    Code Structure: Your code is well-organized and easy to read. Using CSS variables for colors can make future theme adjustments easier and keep your CSS DRY (Don't Repeat Yourself).

    Overall, your solution is solid and functional. With a few tweaks, it can be even more accessible and responsive.

    Keep up the great work!

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub