Social Links Profile

Community feedback

• 

  Adriano•42,870

  @AdrianoEscarabote

  Posted 8 months ago

  Hey JustAsteri, how’s it going? I was really impressed with your project’s result, though I have some advice that could be helpful:

  To enhance the semantics of your code, consider using a <ul> (unordered list) for the collection of links, as it represents a list of related items. Here's an example:

  <ul>
      <li><a href="#">GitHub</a></li>
      <li><a href="#">Frontend Mentor</a></li>
      <li><a href="#">LinkedIn</a></li>
      <li><a href="#">Twitter</a></li>
      <li><a href="#">Instagram</a></li>
  </ul>
  

  Using a <ul> provides clear structure and context, signaling to both browsers and assistive technologies that these links are part of a cohesive group, improving both accessibility and readability.

  Everything else looks great.

  Hope this helps! 👍

  10
• 

  Ammon Quarshie•40

  @niiquash

  Posted 8 months ago

  -Good work on this. -You got the overall design down almost perfectly. -Just need to work on the font colors a little bit more. -I see you're using the BEM method for allocating classes to your elements. Keep it up.

  10