Skip to content
Submitted about 1 year ago

Social Links profile page

Olga•190
@cvtqx
A solution to the Social links profile challenge
Preview (opens in new tab)Code (opens in new tab)

Solution retrospective

What are you most proud of, and what would you do differently next time?

I love the HTML structure of my page, which seems clear and neat, and I tried to follow BEM convention for class naming.

What challenges did you encounter, and how did you overcome them?

I started learning Sass while working on this project. But I couldn't figure out how to deploy webpage with sass in it so I had to remove it from my project and used plain css.

What specific areas of your project would you like help with?

How to deploy a webpage styled with Sass.

Code

Please log in to post a comment

Log in

Community feedback

  • caseem•330
    @kass8mal8

    Your solution is good and includes semantic html.Make the following adjustments and it will be better.

    • The links are embedded in div tags which creates a lot of tags, they should be embedded in li tags for accessibility
    • The bit about sass, use a sass compiler which generates CSS code from your sass then import your CSS as usual.
    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord