Skip to content
Submitted about 1 year ago

social-links-profile using flexbox and css variables

sass/scss
Barak Inbal•40
@BrkCoder
A solution to the Social links profile challenge
Preview (opens in new tab)Code (opens in new tab)

Solution retrospective

What are you most proud of, and what would you do differently next time?

I am proud that it is responsive in most of screen sizes, next time I need to it more close to figma design

What challenges did you encounter, and how did you overcome them?

I have a problem at first with sizes of the elements in the figma because my chrome was on 500% zoom so things didn't fit well

What specific areas of your project would you like help with?

css especially in case of responsive design

Code

Please log in to post a comment

Log in

Community feedback

  • Dylan de Bruijn•3,220
    @DylandeBruijn

    @BrkCoder

    Hiya! 👋

    Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it.

    Things I like about your solution 🎉

    • Use of semantic HTML elements
    • Clear descriptive CSS classes
    • Use of CSS custom properties

    Things you could improve ✍️

    • I suggest adding a bit of padding to your body element so the card has some space around it on smaller viewports.

    • You could add a min-height: 100vh to your body element so it takes up the full height of the viewport while still being able to grow when the content inside it grows.

    • Be careful with setting a fixed width and height on your elements. If the content in these elements grows beyond these restrictions you’ll run into overflow issues. Keeping the height at auto - which block elements are by default - will be fine in most cases.

    • Try putting your links in a list (ul) to make your code more semantic.

    • You don’t have to wrap your image in a separate div, it’s possible to style it directly to achieve the same result.

    I hope you find my feedback helpful! 🌟

    Let me know if you have more questions and I'll do my best to answer them. 🙋‍♂️

    Happy coding! 😎

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord