Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted about 1 year ago

Social links profile using html and css

mayank1405•100
@mayank1405
A solution to the Social links profile challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

Next time I would make this site more functional.

What challenges did you encounter, and how did you overcome them?

No challenge in particular. But I realized something, in the past two projects I mostly used px for dimensions, due to this my website was looking fine when I visited it from my pc, but it looked horrible on mobile and also the screenshot on Frontendmentor. This time I have used vh for giving dimensions. I hope it turns out fine.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Dylan de Bruijn•3,220
    @DylandeBruijn
    Posted about 1 year ago

    Hi @mayank1405,

    Congratulations on completing another great project! I'm happy to see your progress. Very good that you decided to experiment with relative CSS units. You made a good start!

    A bit of friendly constructive feedback:

    • At the moment when you make the viewport smaller you get some overflow issues. The content in the card overflows out of the card. This is due to the height: 58vh; you have on the card.

    About vh:

    vh stands for viewport height. This unit is based on the height of the viewport. A value of 1vh is equal to 1% of the viewport height. A value of 100vh is equal to 100% of the viewport height.

    So when you resize the viewport the size of the card changes as well. In this specific project you don't want the card to resize. You want it to stay centered in the middle at a fixed width until the width of the viewport gets smaller and then the card scales with that. I'll give you a nudge in the right direction. Try setting the with of the card as a fixed value and let the content of the card decide the height. Again it's very good that you experimented with viewport units to get it to look better on mobile, it's just getting to know when and where to use the different units.

    • I suggest using pixel or percentage values for border-radius. You generally don't use viewport units for the border-radius property because you want it to stay the same on any device.

    • I see you use a lot of ID's. Am I safe to assume you do this because you want to style things specifically? It's alright to just use classes for this. You could name your h2 .card-title for example. And the p under that as .card-description. You can read about when to use class or id here.

    I hope this answers your questions. I would appreciate it greatly if you could mark my comment as helpful if it did help you out!

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub