Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Social Links Profile using HTML CSS and media queries

@cintiavic

Desktop design screenshot for the Social links profile coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


What are you most proud of, and what would you do differently next time?

I think it looks pretty much similar to the asked design.

What challenges did you encounter, and how did you overcome them?

Not having the Figma file made me spend more time in working out the styles.

What specific areas of your project would you like help with?

Still need to practice Media Queries

Community feedback

Daniel 🛸• 35,480

@danielmrz-dev

Posted

Hello @cintiavic!

Your solution looks great!

📌 Instead of using <div> as a container and <button> as list items, it's recommended to use semantic HTML elements like <ul> and <li> for creating lists. This ensures that your code is more accessible, maintainable, and semantically meaningful.

Here's how you can refactor your code:

Before Refactoring

<div class="card__linkbuttons">
    <button>Github</button>
    <button>Frontend Mentor</button>
    <button>LinkedIn</button>
</div>

After Refactoring

<ul class="card__linkbuttons">
    <li><a href="#">Github</a></li>
    <li><a href="#">Frontend Mentor</a></li>
    <li><a href="#">LinkedIn</a></li>
</ul>

By using <ul> and <li>, you convey the structure of your content more clearly, making it easier for screen readers and search engines to understand. Additionally, it aligns with best practices for HTML semantics.

I hope you find this helpful!

Keep up the excellent work!

Marked as helpful

0

@cintiavic

Posted

@danielmrz-dev I really appreciate your feedback! It's really helpful, I've never taken notice of / learnt about taking screen readers into account. Thanks for your time!

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord