Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted about 1 month ago

social links profile with hover button

Binh05•370
@Binh05
A solution to the Social links profile challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What challenges did you encounter, and how did you overcome them?

when i font-size the line <p>"Front-end developer and avid reader."<p/>, the card also shrinks, how can i fix it?

What specific areas of your project would you like help with?

Can you comment on the html structure to help me write it more correctly?

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • EFEELE•400
    @EFEELE
    Posted about 1 month ago

    Hello my friend, congratulations on your work! 🎉

    📉 Card Shrinks When Increasing Font Size — Explanation and Fix

    You're right in noticing that the card shrinks when you increase the font size of the <p> tag.
    This happens because the parent container (<main>) does not have a fixed width, only a max-width.
    When you increase the font size, the paragraph may reflow and take up more vertical space,
    but the layout might also appear "shrunk" if it's relying solely on max-width.

    ✅ Solution

    You can fix this by setting an explicit width or using width: 100% along with max-width, like in this example:

    main {
      width: 100%;
      max-width: 400px;
      text-align: center;
      border-radius: 10px;
      padding: 2rem;
      margin: 1rem auto;
      color: var(--White);
      background-color: var(--Grey-800);
    }
    

    🧱 HTML Semantic Improvement

    To improve the semantic structure of your HTML, I recommend using an <article> element for the "card" content and placing it inside the <main>.
    This enhances accessibility and makes your markup more meaningful:

    <main>
      <article>
        ...
      </article>
    </main>
    

    Also, if you're not using <header> or <footer>, feel free to remove them to simplify your code.
    Your HTML is otherwise well-written. Keep up the great work! 💪

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub