Skip to content
Submitted about 2 months ago

Social Links with HTML and CSS

kieranichiban•30
@kieranichiban
A solution to the Social links profile challenge
Preview (opens in new tab)Code (opens in new tab)

Solution retrospective

What are you most proud of, and what would you do differently next time?

i think i got pretty close with the design. Im trying to get a grasp on BEM methodology

What challenges did you encounter, and how did you overcome them?

just naming things with BEM

What specific areas of your project would you like help with?

mainly CSS and BEM naming convention

Code

Please log in to post a comment

Log in

Community feedback

  • Hansel•120
    @Hanseldev

    You forgot to round the card's border. Consider adding a height and width attribute to your image so your browser knows to reserve space in the layout before the image loads. Your variables need more definitive names IMO. Something you don't need to look at before typing. --text-color is very definitive. I also noticed you may not have used the font size in the style readme.

  • Luis Lozano•70
    @lslozano

    Your design is almost there! Great job. You could work on making the font more accessible, since it's a little bit small. Also, the anchors should be bumped a little.

    Besides that, great work!

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord