This button element does not have a name available to an accessibility API. Valid names are: title undefined, element content, aria-label undefined, aria-labelledby undefined.
<button class="themeSwitcherButton"></button>
Looking to hire developers?
<button class="themeSwitcherButton"></button>
<img class="socialIcon" src="./images/icon-facebook.svg">
<img class="upArrow" src="./images/icon-up.svg">
<img class="socialIcon" src="./images/icon-instagram.svg">
<img class="upArrow" src="./images/icon-up.svg">
<img class="socialIcon" src="./images/icon-twitter.svg">
<img class="upArrow" src="./images/icon-up.svg">
<img class="socialIcon" src="./images/icon-youtube.svg">
<img class="upArrow" src="./images/icon-down.svg">
<img class="socialIcon socialIconbottom" src="./images/icon-facebook.svg">
<img class="upArrow overviewArrow" src="./images/icon-up.svg">
<img class="socialIcon socialIconbottom" src="./images/icon-facebook.svg">
<img class="upArrow overviewArrow" src="./images/icon-down.svg">
<img class="socialIcon socialIconbottom" src="./images/icon-instagram.svg">
<img class="upArrow overviewArrow" src="./images/icon-up.svg">
<img class="socialIcon socialIconbottom" src="./images/icon-instagram.svg">
<img class="upArrow overviewArrow" src="./images/icon-up.svg">
<img class="socialIcon socialIconbottom" src="./images/icon-twitter.svg">
<img class="upArrow overviewArrow" src="./images/icon-up.svg">
<img class="socialIcon socialIconbottom" src="./images/icon-twitter.svg">
<img class="upArrow overviewArrow" src="./images/icon-up.svg">
<img class="socialIcon socialIconbottom" src="./images/icon-youtube.svg">
<img class="upArrow overviewArrow" src="./images/icon-down.svg">
<img class="socialIcon socialIconbottom" src="./images/icon-youtube.svg">
<img class="upArrow overviewArrow" src="./images/icon-down.svg">
Any feedback appreciated! Cheers
Hey David, well done on this challenge π It looks pretty close to the design, is responsive, the theme switcher works, and you included hover states on the cards. Your CSS is also organized nicely. I just have a few suggestions for you:
It would be nice if the switcher worked if the user clicked on any part of it, not just the circle part of it.
The design shows a hover state in light mode for when the user hovers over the switcher. The pill-shaped part of it should turn to the linear-gradient.
The layout starts to get a little wonky between 1000px and 1200px screen width because the large cards aren't centered with the small cards.
It would look nice if at tablet screen widths you had the cards laid out in two columns instead of jumping from four columns to one column at 1000px.
1
Join over 180,000 people taking the challenges, talking about their code, helping each other, and chatting about all things front-end!