Our reporter did not find any issues in this project! 🎉
ApplePieGiraffe’s questions for the community
Hey, everybody! 👋
This was an awesome challenge that was a little trickier than I initially thought! 😅
This was my first time creating a site with light/dark themes but I'm pretty happy with the result. I added this cool transition that ripples over the cards when the theme is changed! 😆
As usual, feedback is welcome and appreciated! 😊
And as always, happy coding! 😁
That's really cool.. A question how to make the icons fixed to the cards.. in my solution when I try to change the resolution, it changes positions.
I used flexbox to lay out the elements in the first row of cards on the page and CSS grid to lay out the elements in the the rest of the cards. I think keeping the icons in place when the size of the screen changes is a matter of making sure the icons are correctly placed within their container (which you can do with properties like
align-items for flexbox and
justify-self) and that the size of the card itself is large enough for the items inside it (so that they don't get squished or start being pushed around). 😉 Feel free to use the dev tools to inspect the code for this solution and poke around. Doing that often helps me learn a lot from other people's solutions. 😅
@ApplePieGiraffe Thanks! I did it and I was using flexbox for the second small cards too but when I start using grid it made it easier and less code.
Thanks again. 😉 for a Helping a Newbie
@ApplePieGiraffe Here you can see what i have done: https://distracted-noether-27fb8c.netlify.app
No problem! 👍
The layout of the cards in your site is looking pretty good, right now! 😀
@ApplePieGiraffe Thanks man
Can't believe I missed this! I haven't done this challenge yet, but had to drop in to let you know that theme switch transition is fantastic! 🙌 Definitely bookmarked for when I get around to this one.
This is so good!
P.S. Your profile says you're a newbie, but I don't believe it. :)
Great job as always! I came to see your solution to learn something new. The only thing that caught my eye in this great project was the lack of toggle button animation. What I could suggest is:
- Maybe instead of adding
.toggle-switch__btn--inactiveclass to your
#toggle-switchbutton and change
flex-endyou should add this inactive class to your
transform: translate()on it. Combining this with transition on your circle element you'll get nice and smooth animation. I hope that what I wrote makes sense.
Good luck, have fun coding :)!
I was actually thinking of doing something like that but I just got lazy and went with using flexbox to quickly change the position of the circle element. 😆 But as you suggested, I think the tiny bit of extra effort would be worth it, though! 😁
Thanks for the feedback! 😊
Join our Slack community
Join over 180,000 people taking the challenges, talking about their code, helping each other, and chatting about all things front-end!