Looking to hire developers?
Hi, Could you please have a look on BEM I used in the challenge? Does the name of the classes make sense? This is my 3rd project with BEM... Is there any other method how to code a rounded item inside the toggle button? I create <div> inside <button> How can I move the content to the middle of the page without cutting the top grey background on right and left side?
I would appreciate any feedback from you.
Thank you and Happy Christmas for all of you :)
@ApplePieGiraffe
Posted
Hey, Marta! 👋
Merry Christmas! 🎄 And nice job on this challenge! 👏
I think your BEM looks fine! Perhaps box__small could be box--small, though—since "small" seems more like an adjective (and therefore, a modifier rather than an element of box)—but that's a small thing! 😉
Simply follow the helpful suggestions given by the others and I think you'll be good to go! 👍
Keep coding (and happy coding, too)! 😁
@abhik-b
Posted
Hi Marta, Good job on this challenge ! I really liked it 💯
Just some opinions ~
width to a element and then giving margin: 0 auto can easily center that element on X-Axis with respect to parent elementdetails__btn have position:relative , then give that pseudo element a
position absolute ; top:50%; transform:translateY(-50%) to center it on y axistransform:translateX(some-value) to move the toggle buttonHappy Christmas 🥳
@iMervinC
Posted
Great job! Looks great!
To center your content just add {margin: 0 auto} to your wrapper and apply the background color to the body.
Add check this out too. Might help with your toggle. (https://codepen.io/designcourse/pen/OGVZjr)
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord
