Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 5 months ago

social media link with html and css

Cipher126•120
@Cipher126
A solution to the Social links profile challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)
Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • P
    Aleji0309•150
    @Aleji0309
    Posted 5 months ago

    Areas for Improvement: Profile Name (<h1>): The name “Jessica Randall” is placed within an <h1> element, which is good for importance and SEO, but it could be more specific. For a single person, it might be better to wrap the name in an <article> element, signifying that this is a standalone piece of content about Jessica.

    Missing <header>: The profile section could benefit from a <header> tag around the name and other introductory information, which would make the structure clearer.

    Social Links: While the social links are placed inside a <section>, they would be even more semantically accurate if placed inside a <nav> element, as they are navigation links.

    The <footer>: The footer uses the <footer> element correctly, but the attribution could benefit from being wrapped in a <p> tag or similar, for better text grouping.


    CSS Inline Styles:

    The style tag for the attribution in the HTML head is not ideal. For better organization and maintainability, it’s better to move those styles into the main external CSS file (style.css).

    CSS Specificity and Redundancy:

    The CSS is mostly well-organized, but some selectors could be made more specific to avoid unnecessary redundancy. For example, the .textContainer h1 and .textContainer .london selectors have margin-right defined multiple times, which might be better consolidated or adjusted.

    CSS Variables:

    Using CSS variables for commonly used values like colors or font sizes could make the code more reusable and easier to maintain.

    Suggestions for Improvement: Refactor Inline Styles:

    Move the inline styles in the

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub