Karol Binkowski• 1,640
@GrzywN
Posted
Great job!
- You can use header tag, it's more about how you see your site than something being correct or not correct. If you see your project being section for some other page you can wrap everything into main tag as you did. If you see your project as a whole website, you can use header instead.
- Great job, as you did, you should use rem units all the time. Sometimes pixels are converted to rem with precision loss, so be careful. You can use VS Code extension to alternate between px and rems with one keyboard shortcut.
- I think it looks great, you can take a look at other solutions to see how others handled this thing.
- To match the design with your project:
- you can set your background to design image
- you can use DiffChecker website
- you can use PerfectPixel extension for Google Chrome
Hope this helps! Keep coding and have a nice day!
Marked as helpful
2
Jason Greenwald• 200
@jaycgreenwald
Posted
@GrzywN Many thanks for your detailed answers to all of my questions. The VS Code suggestion is amazing. (I'm currently finding the value in pixels then doing the math to convert to rem.) I'm excited to try out the tools you suggested for comparing my work to the design images. Thank you again and cheers!
1
