@vanzasetia
Posted
Hi, Lo-Deck! 👋
For margin
and padding
, I recommend using rem
. Most of the time, it is better to have a consistent space.
You can use fluid space by using viewport units and clamp()
function. You need to make sure the minimum and the maximum value using rem
unit. If you use a viewport or percentage unit, the space will keep changing.
This tool can help you generate fluid space — Fluid Responsive Design | Utopia
In this case, I think it is better to use grid-template-areas
. You can divide it into three areas. The first area is the "10,000+ of our users love our products" and the below paragraph. The second area is the ratings. The third area is the testimonials.
Also, you may only need four columns instead of 12 columns. For the desktop layout, two columns for the first area and the second area. The testimonials take all four columns.
Here are some suggestions for improvements:
- Simple format: You should write
2rem
instead of2.0rem
. - Unitless
line-height
: Always use unitless numbers forline-height
values to avoid unexpected results. Learn more — line-height - CSS: Cascading Style Sheets | MDN
I hope this helps. Happy coding! 😄
Marked as helpful
@vanzasetia Thanks for your comment and your links. It is very helpful.
@vanzasetia
Posted
@Lo-Deck
Happy to hear that was helpful! 😊