@correlucas
Posted
👾Hello @tarasis, Congratulations on completing this challenge!
Great code and great solution! I’ve few suggestions for you that you can consider adding to your code:
You did a really good work here putting everything together, something you can improve its your code html markup and semantics. You can replace the <div> that wraps each card with <article> you can wrap the paragraph with the quote with the tag <blockquote> this way you'll wrap each block of element with the best tag in this situation. Pay attention that <div> is only a block element without meaning.
This article from Freecodecamp explains the main HTML semantic TAGS: https://www.freecodecamp.org/news/semantic-html5-elements/
✌️ I hope this helps you and happy coding!
Marked as helpful
@tarasis
Posted
@correlucas cheers Lucas, I wasn't sure if <article> was an approriate wrapper for the top and bottom sections, hence using a <div> It didn't strike me that they were really self contained things that might be shown separately.
(As it was I was hesitant about using the <section> tags, and also debated making my <header>` a section.).
Bit confused about the <blockquote> suggestion, as I did use that to wrap the <p>
Thank you!
