Hey @Ace953 👋🏻
I have some quick tips to help you fix the accessibility issues and some other things.
- First, in your markup,
<div class="wrapper">...</div>should be<main class="wrapper">...</main>and<div class="attribution">...</div>should be<footer class="attribution">...</footer>. These will fix the accessibility issues. Don't forget to generate a new repot once you fix the issues. - For the star icons, add
aria-hidden="true”, because they're for decoration. You can read more aboutaria-hiddenhere. - Also, add
min-height: 100vhtobodyso thebackground-imagecan stretch all the way down. - Lastly, as already suggested, remove
overflow: hidden;otherwise, the user can only see the half of the content.
I hope this was helpful 👨🏻💻 Other than that, you did a great good job, nicely done. Cheers 👾
Marked as helpful
1
Ace953• 60
@Ace953
Posted
@kens-visuals Thank you very much for your feedback, it was very helpful.
I've applied your corrections. Now you are able to see the mobile version as well.
I first put the property overflow: hidden to delete the vertical scrollbar. How can I remove it?
0
@Ace953 you should have a vertical scrolling, without scrolling we won't be able to see the content, and there's too much content to fit on a screen without scrolling.
Marked as helpful
1
