@correlucas
Posted
๐พHello Nien, congratulations for your new solution!
๐จ Youโve done really good work here putting everything together, Iโve some suggestions to improve the design:
1.To add the two wave
svg background images in the (top/bottom),, the best way is by using background-image
to manage it since adding them to the body
you make sure it will be under everything, to manage different images inside a single css property as background-image
you use the comma inside each properties declare the single modification for each circle separated. See the code below to see your solution with those backgrounds applied:
body {
background-image: url(images/bg-pattern-top-desktop.svg), url(images/bg-pattern-bottom-desktop.svg);
background-position: left -185px top -236px, right 10px bottom -300px;
background-repeat: no-repeat, no-repeat;
background-attachment: fixed, fixed;
background-size: contain, contain;
}
2.Improve your code html markup and semantics. You can replace the <div>
that wraps each card with <article>
you can wrap the paragraph with the quote with the tag <blockquote>
this way you'll wrap each block of element with the best tag in this situation. Pay attention that <div>
is only a block element without meaning.
โ๏ธ I hope this helps you and happy coding!
Marked as helpful
@trandainien
Posted
@correlucas really appreciate all your feedback. I will keep them in mind. Thank you