@darryncodes
Posted
Hi Asmae,
Overall a good solution, a pretty close match to the design.
A few thoughts from me:
- you relative file paths are causing the images not to display, as everything is in the same folder you just need to link to the exact image you need. Here is some useful info on this topic
- you have a lot of accessibility and html errors, look into using semantic html like
<main>
and<footer
tags - and take a look into your heading structure. You should usually have one
<h1>
and then not skip heading levels after that - I think you have relied on padding and margin a lot to layout your design, with absolute units it can play havoc with your responsive design. Here is a Complete Guide to Flexbox that is worth really studying and learning
- You could consider using transform: translate x/y to achieve the staggered card affect instead of margin. I think it might be a little simpler from a responsive design perspective
Good luck with it all!
Marked as helpful
@Asmae-Amahrouk
Posted
@darryncodes THANKS!!!.. I really appreciate it !!! that will help me a lot ... I will take all your notes into consideration and work hard to improve my code ... : )