@elaineleung
Posted
Hi Mohammed, great job completing this, and yes, the positioning and sizing can be tricky!
About your question on the card divs, you can try changing the width
in .reviews__card
to max-width
instead. That would allow the component to be resized when the browser width shrinks, and it seemed to work for me when I changed it in the inspector just now. You can try experimenting with responsive properties in other containers, and see whether that helps with the responsiveness.
I also completed this solution a while and just recently updated; you can check it out too and see whether it gives you any ideas.
By the way, I just noticed that your report has a number of issues; I think you already fixed the missing alt
tag (which you can actually keep empty as alt=""
since it's just an icon, and I'd also add a aria-hidden
for those img
tags so that the screen reader can skip them). In case you made the fix already, what you can do is to update the report, and before you do that, you can change the <div class="container">
in your HTML to <main class="container">
, which should take care of one or two other issues.
Good luck, and well done!
Marked as helpful
@abedmohammed
Posted
@elaineleung Thank you so much, this is really helpful!