Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Social proof section

@abedmohammed

Desktop design screenshot for the Social proof section coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I was struggling a lot with responsiveness, I was not sure why things were not scaling down and I didnt know where to start on how to make the divs get smaller on their own as I minimized the scren. Everytime I would minimize, my margins and div would start sliding out of the screen, instead of resizing the div to fit the content.

Community feedback

Elaine 11,420

@elaineleung

Posted

Hi Mohammed, great job completing this, and yes, the positioning and sizing can be tricky!

About your question on the card divs, you can try changing the width in .reviews__card to max-width instead. That would allow the component to be resized when the browser width shrinks, and it seemed to work for me when I changed it in the inspector just now. You can try experimenting with responsive properties in other containers, and see whether that helps with the responsiveness.

I also completed this solution a while and just recently updated; you can check it out too and see whether it gives you any ideas.

By the way, I just noticed that your report has a number of issues; I think you already fixed the missing alt tag (which you can actually keep empty as alt="" since it's just an icon, and I'd also add a aria-hidden for those img tags so that the screen reader can skip them). In case you made the fix already, what you can do is to update the report, and before you do that, you can change the <div class="container"> in your HTML to <main class="container">, which should take care of one or two other issues.

Good luck, and well done!

Marked as helpful

0

@abedmohammed

Posted

@elaineleung Thank you so much, this is really helpful!

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord