Hey @nikharg 👋🏻
I have some suggestions for the desktop layout, the accessibility issues, and some minor things.
- For
.top
removepadding-left
completely, because it's causing some problems on the layout, by pushing the text too far left. - For
.card-rating
reducepadding-right
to80px
, so it aligns with the comment boxes. -<div class="attribution">...</div>
should be<footer class="attribution">...</footer>
. <h4>
of the names should either be<h2>
or<p>
, because headings in HTML have to decrease gradually. These will fix the accessibility issues, just, don't forget to generate a new repot once you fix the issues.- Next, the star icons should have
aria-hidden="true”
, like so<img src="./images/icon-star.svg" alt="" aria-hidden="true”>
, because they're for decoration. You can read more aboutaria-hidden
here. - One last thing, for the mobile viewport width, remove
overflow: hidden;
so it can be scrolled.
I hope this was helpful 👨🏻💻 you did a great job with responsiveness, keep it up. Cheers 👾
Marked as helpful
0
Nikhar Gupta• 80
@nikharg
Posted
@kens-visuals Thank you so much sir for your suggestions! It really helped me a lot. Thanks for supporting me again!!🙏
0
@nikharg no problem, I'm glad I could be helpful 😇
Marked as helpful
0