@vanzasetia
Posted
👋Hi Gutka! First, I can't find the CSS file on your GitHub repo 😅. I also had see the source code, but I couldn't open the CSS file.
I have some feedback on this solution:
- Heading order is important. You need to use
h2
first, before you can useh3
. - Rated 5 Stars... should not be a heading. Heading tags is used for titling section. If you think that is an important information, I recommend to use
strong
tag. - The
alt
value should not be hyphenated. It should be human readable and informative. - The star icons are decorative images. Remember, for any decorative images, you should leave the
alt=""
and addaria-hidden="true
orrole="presentation"
. Or you can just usebackground-image
as Tediko said. - If you're going to use
background-image
, there's a gotcha. You need to change thewidth
value on theicon-star.svg
file to create a space. I recommend to increase it to22
(based on Tediko Solution) to create a space on the right side of the icon, since you can't usemargin
orpadding
on background. - The
feedback__name
should not be a heading too. - For the
alt
value for the photo, I recommend to just fill it with their name.alt="Colton Smith"
.
That's it! Hopefully this is helpful!
Marked as helpful
@karbowskam
Posted
@vanzasetia thank you very much for your detailed advices. It will help me in my further learning. I love writing code in SCSS format so there is no CSS file in my repo 🙈
@vanzasetia
Posted
@karbowskam I also really ❤️ Sass with SCSS syntax, but usually the Sass files will get compile into CSS file. So how it can be possible without any CSS? Even though your HTML linking to css/style.css
which is doesn't exist on your repo 😅.