This is an amazing start @royschrauwen. I am happy for you.
I have a few recommendations:
-
Avoid setting solid heights and widths, use
min-height
,max-height
,min-width
&max-width
instead. For example on the container you can have something like this:min-height: 100vh; max-width: 50rem; margin: 0 auto;
-
On the example above I have used
margin: 0 auto
to centre content, it only works if you have set the width. -
You don't need to set margin-top / margin-bottom on when using flex or grid layout, just use the
gap
property.
Cheers.
Marked as helpful