Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Social proof section | HTML CSS Sass

Pop Andreiβ€’ 120

@pccipri

Desktop design screenshot for the Social proof section coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


πŸ‘‹Hello thereπŸ‘‹ Just finished this challenge and it took a bit longer than the rest but I think it's okaish. Anyway if u have any advice on responsiveness or just an opinion of my code and how it can be improved let me know. Thank you for taking your time to read this.Have a great day!

Community feedback

P
Kenβ€’ 4,915

@kens-visuals

Posted

Hey @pccipri πŸ‘‹πŸ»

I have some suggestions to help you fix the accessibility and HTML issues.

  • Pretty much every <img> tag in this project, besides user profile pictures, should have aria-hidden="true". Like, the following examples:
<img class="bg-top-image-desktop" src="images/bg-pattern-top-desktop.svg" aria-hidden="true">
<img src="images/icon-star.svg" aria-hidden="true">

this should fix all the accessibility and HTML issues. Don't forget to generate a new repot once you fix the issues.

  • One small suggestion would be to add some padding to star review boxes.

I hope this was helpful πŸ‘¨πŸ»β€πŸ’» overall, you did a nice job, it looks pretty good on mobile viewport width. Cheers πŸ‘Ύ

Marked as helpful

1

Pop Andreiβ€’ 120

@pccipri

Posted

@kens-visuals Thanks a lot for the review and the ideas.

0
P
Kenβ€’ 4,915

@kens-visuals

Posted

@pccipri you're welcome πŸ˜‡

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord