Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted almost 4 years ago

Social proof section master with html and css.

Thais•255
@thaiscode
A solution to the Social proof section challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Any feedback is welcome :)

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Vanza Setia•27,715
    @vanzasetia
    Posted almost 4 years ago

    👋 Hi Thais!

    I have some feedbacks on this solution:

    • Accessibility
      • For any decorative images, each img tag should have empty alt="" and aria-hidden="true" attributes to make all web assistive technology such as screen readers or screen magnifiers ignore those images. In this case all images are decorative only except the photo images.
      • For the photo images, I would recommend to use their name as the alternative text.
      • Headings should be chronological order. You should use h1, h2, h3 until h6 in a logical order. Logical heading order will make all users that use assistive technologies such as screen reader can navigate the website easily.
      • Use rem or sometimes em unit instead of px. Using px will not allow the users to control the size of the page based on their needs.
    • Non Accessibility
      • The design width size should not be your breakpoint for your media query most of the time. In this case on screen that has width less than 375px will see desktop layout, since you're forcing the body element to have 1440px.
      • Setting body element to have minimum 900px height is not good for responsiveness.
      • I would recommend to write your stylesheet with mobile first approach, which means your base styling (CSS code outside the media query scope) should be for styling mobile layout and then after that you can use @media (min-width: <size>) to style bigger screen size.
      • Don't forget to see your website on mobile landscape mode.
      • I notice an id selector on your stylesheet (#stars-box). I would recommend to change it to class to prevent high specificity unnecessarily in your stylesheet.
    • Question
      • Why do you wrap every photo img tag with figure tag? Could you explain that to me?

    That's it! Hopefully this is helpful!

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub