Connor Z• 5,115
@zuolizhu
Posted
Hey Luis,
Nice job on this challenge👍!
I think you can put the attribution inside the <main></main>, otherwise you will see there is a big gap between the attribution and the main. Also, margin-top: 80rem; of the .attribution seems too big after screen size 768 px.
The comments you added make your code much easier to read! However, if you try to make attribution as a footer, then instead of div, using footer to improve the semantic structure. You can check out this article for more 👉**semantic html**
I'm looking forward to your next project😜 Happy coding 🙌!
1
