Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Social proof section

Elodieβ€’ 190

@MitiaElodie

Desktop design screenshot for the Social proof section coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

@VCarames

Posted

Hey there! πŸ‘‹ Here are some suggestions to help improve your code:

  • The profile images alt tags need to be improved ⚠️. It should state the following; β€œHeadshot of -person’s full name-β€œ

More Info:πŸ“š

Headshot Alt Text

  • For the testimonials, it is best βœ… to to wrap each individual testimonial component in a figure element, the individuals information should be wrapped in a figcaption element and lastly, the testimonial itself should be wrapped in a blockquote element.

Code:

<figure>
   <blockquote></blockquote>
   <figcaption></figcaption>
</figure>

More Info:πŸ“š

MDN Figure Element

  • Your CSS Reset is being underutilized. 😒 To fully maximize πŸ’― it, you will want to add more to it. Here are some examples that you can freely use 😁: Josh Comeau Reset Eric Meyer Reset
  • For improved accessibility πŸ“ˆ for your content, it is best practice βœ… to use rem for your font-size and other property values. While em is best for media-queries. Using these units gives users the ability to scale elements up and down, relative to a set value.

If you have any questions or need further clarification, feel free to reach out to me.

Happy Coding! πŸŽ†πŸŽŠπŸͺ…

Marked as helpful

0
Alaminβ€’ 1,960

@CodePapa360

Posted

Hi ElodieπŸ‘‹ Great job on completing this challenge! πŸ₯³

Overall, it seems to be well-structured and easy to understand. However, there are a few areas that could be improved:

  • There is a lot of repetition of the same code for different rating containers. For example, the following classes have the same styles:
    background-color: $light-grayish-magenta;
    color: $very-dark-magenta;
    border-radius: 10px;
    margin-bottom: 15px;
    padding: 15px;
    display: flex;
    justify-content: center;
    align-items: center;
    flex-direction: column;
    gap: 10px;

You could make use of a class for each rating container to improve the maintainability of the code.

  • The SVG files for the star icons are being repeated multiple times within the HTML file. It would be more efficient to use a single file and reuse it multiple times with CSS.

  • There's some classname which is not self-explanatory, you could make use of more informative classname to improve the readability of the code. such as social-proof__rating-container could be something like social-proof__review-details as it holds the rating details.

Overall, this is a very well done solution to the challenge. Great job!

Hope I'm Helpful! πŸ‘

Keep up the good work! 😊❀️

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord