@LawrencePryer
Posted
Hi Sagar
This looks great! I am currently struggling through this same challenge myself so it is interesting to see how you did this. My one suggestion would be regarding your variables for CSS. Rather than naming the variables after the actual colours (e.g. --dark-magenta) , I understand it is good practice to call them things like "color-primary" and "color-secondary". This way if a company decides to change the colour scheme in the future, you don't have to change the variable names. For example if the company decided to change from a dark magenta to a dark orange, you would need to go through and change all your variables throughout the code, rather than just the colour codes in the :root section.
I hope that helps and makes sense. Hopefully somebody more experienced can confirm whether my suggestion is a good one or not.
