Not Found
Not Found
Not Found
Failed to decode param 'kaan%F6zdemir'
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Social Proof Section using vanilla CSS and Flexbox.

P
C Lewis 90

@casserole27

Desktop design screenshot for the Social proof section coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View Challenge

Design Comparison

SolutionDesign

Report

15

Accessibility Issues

15

HTML Issues

View Report

C Lewis’s questions for the community

I'm happy with my solution, but if anyone has any suggestions, I'm continually looking for ways to make my CSS more efficient and seamless between mobile and desktop. Thank you!

Community Feedback

@freakyjones

Posted

Hello Clewis,

congratulation on completing the challenge. I just saw your code, Here is my one suggestion that may help you in the future.

Use of universal operator to get rid of the default browser Style instead of using margin:0, padding:0 for every device

*{
  margin:0;
  padding:0;
 box-sizing:border-box
}

I hope it helps, Thanks Happy coding :)

Marked as helpful

1


P
C Lewis 90

@casserole27

Posted

@freakyjones noted! Thank you!

1

Eray 1,360

@ErayBarslan

Posted

Hey there, nice work with this one! I see you've tried to center your content but you need an addition for it to work:

html {
    height: 100%;
}

body {
    ...
    min-height: 100%;
}
  • You should move background-color and image from .body-wrapper to body element. Right now background doesn't cover wide screens. Use the wrapper just to align your content.
  • Also if you use max-width on containers instead of a fixed width, your page becomes more responsive.
  • You have a good usage of media-query, but you might want to increase min-width value as content overflows on certain screens. These are my suggestions to improve your solution, happy coding :)

Marked as helpful

1


P
C Lewis 90

@casserole27

Posted

@ErayBarslan I will look into width and height mins and maxes. I changed the background settings from body-wrapper to body, thank you.

0

Adriano 11,920

@AdrianoEscarabote

Posted

Hello, how are you?

Congratulations on the result of your project, it really turned out very good. But try to pay more attention to how the project adapts to different resolutions, both higher and lower.

On my monitor the project was a little broken, but I managed to solve it as follows:

body { min-height: 100vh; }

I also removed the background-color from the body. To not look like the layout is broken.

the rest is very good hope it helps... 👍

Marked as helpful

1


P
C Lewis 90

@casserole27

Posted

@AdrianoEscarabote I changed the background settings from body-wrapper to body, thank you.

1

Please log in to post a comment

Log in with GitHub
Slack logo

Join our Slack community

Join over 100,000 people taking the challenges, talking about their code, helping each other, and chatting about all things front-end!