Social proof using Flexbox

Community feedback

• 

  

  ApplePieGiraffe•30,525

  @ApplePieGiraffe

  Posted over 4 years ago

  Hello, Joran Minjon! 👋

  Nice to see you complete another challenge! 😀 Well done on this one! 👍 Your solution looks good and responds well! 👏

  A minor suggestion I have is to add a max-width to the content of the page so that it doesn't become too stretched on extra-large screens. You might also want to add a max-width to the testimonial cards so that they aren't too wide when the layout first changes from desktop to tablet/mobile (that'll make the text inside those cards easier to read, too).

  Your placement of the background images seems good to me! 😀 I don't think you need have to include the "0"s in background-position: top 0 left 0, bottom 0 right 0 (you can simply have background-position: top left, bottom right) and I don't think you need to specify the sizes for the background images in this challenge (I think they are the correct size already and not defining their size in percentages will make them look more consistent across screen sizes—but they are background shapes that don't look bad even when skewed, so it might not matter too much). 😉

  Keep coding (and happy coding, too)! 😁

  30
• 

  

  Grace•32,130

  @grace-snow

  Posted over 4 years ago

  Looks pretty good.

  Next time try mobile first instead and one definite change needed is swapping all alt="star" for alt="".

  I don't think it's valid to have header elements inside list items. I would use divs instead, as extra banner roles (headers) can actually cause problems for assistive tech navigating the conteng, not help those users. Not a massive issue but something to be aware of.

  Good job

  10
• 

  Joran Minjon•610

  @DrKlonk

  Posted over 4 years ago

  Thanks both! I made the updates and changes. Ready for shipping now ;)

  00