Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 1 year ago

Social-Links-Profile

Neel Mishra•240
@Neel-07
A solution to the Social links profile challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


I have recently completed a project and would greatly appreciate any feedback you may have. I am eager to learn and improve, so I welcome constructive criticism or suggestions for enhancement. Your insights on any potential mistakes or areas for improvement would be invaluable in helping me grow and develop as a professional. Your feedback will not only benefit this project but also contribute to my future endeavors. Thank you in advance for taking the time to share your thoughts.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Grace•32,130
    @grace-snow
    Posted over 1 year ago

    Hi

    The biggest problem I see here is that you've added a hover style to the li elements not the anchors. The whole block needs to be clickable, not just the text in the center of each list item.

    You also must not do this:

      height: 100vh;
      width: 100vw;
    

    Never limit the height of elements that contain text, including the body. This solution breaks on smaller screens especially in landscape orientation because of the height 100vh. Instead, change it to min-height.

    The body is already full width. Don't use 100vw ever as that can only cause overflow (unwanted horizontal scroll) whenever a scrollbar is present for some users.

    The card must not have a height or width. Use max width in rem and let the browser decide how tall the card needs to be based off the content inside.

    Add some padding to the body or margin to the component so it can't hit screen edges.

    Look up how to write alt text on images. There is a good post about this in the discord resources channel.

    It's strange how youre using padding and margin at the moment. Maybe have a read of this and make sure you understand the differences / when to use each: https://fedmentor.dev/posts/padding-margin/

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Frontend Mentor for Teams

Frontend Mentor for Teams helps companies and schools onboard and train developers through project-based learning. Our industry-standard projects give developers hands-on experience tackling real coding problems, helping them master their craft.

If you work in a company or are a student in a coding school, feel free to share Frontend Mentor for Teams with your manager or instructor, as they may use it to help with your coding education.

Learn more

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub