social-media-dashboard-with-theme-switcher-master

Community feedback

• 

  Ctrl+FJ•810

  @FlorianJourde

  Posted about 2 years ago

  Hey Eduardo !

  Nicely done, your dark theme is working well !

  Be careful, your responsive solution has some glitches : when screen size is very small (under 350px), your layout begin to break. This is because of using fixed width & height on your .primeiro an .box elements. Of course, nobody have this size layout nowadays, but still, I think it's a good point to think "flexible" ! I would recommend you to avoid these fixed properties when you can, and just play around with paddings & margins.

  As well, it's a tiny detail, but I think it's a better practice to name CSS classes with English language. I struggled too, because of my native language, which is French, haha ! But when coming into big projects, you'll see it's easier to find your way if everything is written in English. I think this advice is valid for every code language you'll meet ✌️

  Keep up the good job !

  01

  Marked as helpful