@elaineleung
Posted
Hi Marko, I think you did well on the whole! The only three suggestions I have are as follows:
-
The ratings and the testimonials are stretching out quite a bit before the browser width reaches the breakpoint. You can either try a smaller breakpoint, or better yet, use a
max-width
for the cards and ratings. I see that you have a max-width on the ratings but it's in a percentage, which means it will still continue to stretch. What I would suggest is to use a relative unit here, like rem. For starters, trymax-width: 25rem
and then adjust accordingly. -
At desktop view, the site main heading has quite a large line height. I tried changing it via the inspector but I was not able to for some reason. In any case, it would be great if that spacing is a bit smaller!
-
Instead of using the
picture
element for the SVGs, try having them asbackground-image
instead because they are merely functioning as decor elements, and they aren't really there to enhance the site content in any meaningful way.
Hope this could help you out!
Marked as helpful
@Frozennn
Posted
@elaineleung Hello Elaine,
Thank you for your wonderful suggestions,
I will implement them and the max-width with rems is a really good idea.
The reason I used the picture element is that I find it to be the easiest solution when changing the images depending on the screen size because of the media attribute.
How would I achieve the same thing if I used a background image? Would media queries be necessary? And if so could you please give me an example of how I could do that?