@itsleeparker
Posted
Thanks for the feedback dude will remember it
Looking to hire developers?
Hey there this is my third post here , as a begginer I am feeling good coding up all the site ,I tried to solve this problem however my CSS is going too long , I am open for suggestions and I would love to hear your opinion on this one. Thats it from my side
@itsleeparker
Posted
Thanks for the feedback dude will remember it
@darryncodes
Posted
Hi Adnan,
Good job, pretty much a perfect match!
Two suggestions form me:
<div class="attribution">
to <footer class="attribution">
and made your <h5>
a <h2>
. You shouldn't skip heading levelsAll the best!
@benjoquilario
Posted
Hi! itsleeparker Great job on finishing this one. Everything looks great responsive well.
Some Suggestion:
Remove the height: 100vh
or just add the min-height: 100vh
on the body tag. Because this will only limit the body to have a height 100% of the remaining viewport or screen.
Also remove the width: 50vh; on your body tag at media (min-width: 345px) and (max-width: 500px)
. Because this will only limit the body to have a width: 100% of the remaining viewport or screen.
Also on your <img tag> you forgot to add the alt attribute. The alt attribute provides an alternative text for an image, if the user for some reason cannot view it. In your case since the photo of image is not decorative you should add the alt attribute on it Example: alt="Colton Smith"
.
aside from those everything is looks fine! Good luck
@itsleeparker
Posted
@benjoquilario Thankyou so much for help dude will keep that in mind 👍
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord