Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 1 year ago

Solution 1

Rares•20
@raresmanta
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


I didn't have much difficulty working on this project, as I had some prior experience with HTML and CSS. It was a great opportunity to remember a lot of the things that my mind let go over time. The main areas of the code I'm unsure of is the CSS part. I don't know if my approach is the most efficient, as I mostly patched up some parts of it (backgrounds had gaps, so I added a background to not only the <body>, but also to the header and paragraph). My main question is regarding the "beauty" of the code in the CSS part. If anyone has any tips for ordering bits of code for ease of use that would be grealty appreciated.

Code
Couldn’t fetch repository

Please log in to post a comment

Log in with GitHub

Community feedback

  • Melvin Aguilar 🧑🏻‍💻•61,020
    @MelvinAguilar
    Posted over 1 year ago

    Hello there 👋. Good job on completing the challenge !

    I have some suggestions about your code that might interest you.

    • You shouldn't use the body element as just another tag; it's meant to encompass the entire content of the webpage. The body element serves as the container for the main content of your HTML document. Using it for anything other than its intended purpose can lead to unexpected layout and styling issues.

      You should add a specific container tag inside the body element, for example, <main>, to encapsulate your entire component. Additionally, adding a background-color to the * selector is not recommended, as it would require you to override it for each individual element. Instead, you can declare background-color: #d4e1ee; directly in your body selector , making it unnecessary to specify it elsewhere.

    • To center the component in the page, you should use Flexbox or Grid layout. You can read more about centering in CSS here 📘.
    • Avoid using 'vh' for font sizes. Screen size alone should not determine text size. For adaptable font sizes, consider using 'clamp,' but relying solely on 'vh' is not practical.

    I hope you find it useful! 😄 Above all, the solution you submitted is great!

    Happy coding!

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub