@Islandstone89
Posted
HTML:
-
The alt text must also say where it leads(frontendmentor website).
-
Use
<p>for the footer text.
CSS:
-
It is best practice to write CSS in a separate file, often called
style.css. Create one in the same folder as theindex.html, and link to it in the<head>:<link rel="stylesheet" href="style.css">. -
Including a CSS Reset at the top is good practice.
-
Add around
1remofpaddingon thebody, so the card doesn't touch the edges on small screens. -
Remove the margin on the card.
-
To center the card and the footer horizontally and vertically, use Flexbox on the body. You must also add some space between them using
gap:
display: flex;
flex-direction: column;
justify-content: center;
align-items: center;
min-height: 100svh;
gap: 2rem;
-
Remove the width on the card - setting fixed sizes in
pxis not recommended, as we want our components to be able to adapt to different screens. -
Add a
max-widthof around20remon the card, to prevent it from getting too wide on larger screens. -
font-sizemust never be in px. This is a big accessibility issue, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead. -
Since all of the text should be centered, you only need to set
text-align: centeron the body, and remove it elsewhere. The children will inherit the value. -
I would increase the
paddingon the card to around16px. -
On the image, add
display: blockand changewidthtomax-width: 100%- the max-width prevents it from overflowing its container. Remove thez-index, it is not needed.
Hope this is helpful - good luck :)
Marked as helpful
