Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 1 year ago

Solution QR code component

web-components
Stefan Bojkovski•720
@xStephx
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)
Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Petrit Nuredini•2,860
    @petritnuredini
    Posted over 1 year ago

    Congratulations on completing the "QR Code Component" project! 🎉 Your project shows a great understanding of HTML and CSS. Here are some best practices and recommendations for further enhancements:

    1. Semantic HTML:

      • Use more semantic tags to enhance the structure and accessibility of your code. For instance, wrapping the main content in a <main> tag is a good practice, which you've done well.
      • In your img tag, consider adding a more descriptive alt text for accessibility purposes, like alt="QR Code for Frontend Mentor".
    2. CSS Best Practices:

      • Organization: Your CSS is well-organized. Keep maintaining this structure as it will help in managing more complex projects.
    3. Code Efficiency:

      • DRY Principle: Always look for opportunities to reduce repetition in your code. This makes your codebase cleaner and easier to maintain.
      • CSS Shorthand: Utilize CSS shorthand properties where possible to make your code more concise.
    4. Accessibility:

      • Keyboard Navigation: Ensure that all interactive elements are accessible via keyboard.
      • Color Contrast: Check that the text and background colors have sufficient contrast, especially for readability.
    5. Further Learning:

      • As you continue your journey, explore topics like CSS animations, flexbox, and grid systems to enhance the visual appeal and layout of your projects.
      • Experiment with different design frameworks like Bootstrap or Tailwind CSS to see how they can speed up your development process.

    Useful Resources:

    • MDN Web Docs for comprehensive learning resources on web technologies.
    • W3Schools for tutorials on HTML and CSS.
    • A List Apart for in-depth articles on web design and development.

    Keep up the great work, and I'm looking forward to seeing more of your projects! 🚀

    Marked as helpful
  • hemel•70
    @hemel17
    Posted over 1 year ago

    Greate work! But for the class a you could use a header tag and for the class b you could use a p tag. Btw, checked your github profile and got some motivation to code daily. Keep up the good work. Thank you. :)

    Marked as helpful
  • Kishore Kumar Mahto•500
    @iamkishoremahto
    Posted over 1 year ago

    nice work

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub