Skip to content
Submitted almost 2 years ago

Solution qr code using CSS Grid and CSS Flexbox

bem, node
Emanuel Bonardo•320
@emanuelcba94
A solution to the QR code component challenge
Preview (opens in new tab)Code (opens in new tab)

Solution retrospective

Feedback welcome. Thank you! Emanuel bonardo.

Code

Please log in to post a comment

Log in with GitHub

Community feedback

  • Vanza Setia•27,715
    @vanzasetia

    Hi, Emanuel Bonardo! 👋

    Here are some suggestions for improvements:

    • No <div> elements: Remove all the <div> elements. The styling of the .container and the .card__container can be merged and put on the <main> element. You do not need to wrap each element with a <div> element.
    • Use owl selector: For spacing between elements inside the card, you can use the owl selector (* + *). For example, you can have .card > * + * { margin-top: 1em }.
    • Alternative text should describe the image: Alternative text for images should not include any words that are related to the word "image". The semantic meaning of the <img> element tells assistive technologies to pronounce it as an image. So, you should describe what is the image and the purpose of the QR code.

    I hope this helps. Happy coding! 👍

    Marked as helpful
  • Tushar Biswas•4,060
    @itush

    Congratulations on completing the challenge! 🎉

    Your solution looks nice to me :)

    • To reset default browser styles you may also add padding: 0;

    In my projects:

    • I always start with mobile-first workflow.
    • I use at least one main element for a page (entire content goes into the main, if I'm not using header & footer), and avoid divs as much as possible and use section and article element wherever I can.
    <body>
<main>
All content 
</main>
</body>
    • I Use relative units as much as possible and avoid absolute units whenever possible.
    • If you are someone who is just starting out with front-end development, I strongly suggest starting with the QR code component project(which you did). Also in the challenges page you may filter by (Newbie, HTML&CSS) sort by (easier first) to select projects that will help you solidify your foundation. To avoid any potential knowledge gap⚠️ please first solidify HTML, CSS, JS fundamentals and then move on to any framework or library.
    • I remember when I started out, I made countless mistakes and spent long hours searching for solutions. But hey, you don't need to go through the same struggles! 🙌 To help you shorten the learning curve, I recommend going through the following articles. They contain valuable insights that can make your journey smoother:

    📚🔍 12 important CSS topics where I discuss about css position, z-index, box-model, flexbox, grid, media queries, mobile-first workflow, best practices etc. in a simple way.

    📚🔍 11 important HTML topics where I discuss about my thought process and approach to convert a design/mock-up to HTML along with important topics like block and inline elements, HTML Semantic Elements.

    I hope you find these resources helpful in your coding adventures! 🤞

    I'm eagerly looking forward to seeing the amazing projects you'll create in the future! 🚀💻

    Keep up the fantastic work and happy hacking! 💪✨

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord