Skip to content
Submitted about 1 year ago

solution to QR code challenge

demaxs26•250
@Demaxs26
A solution to the QR code component challenge
Preview (opens in new tab)Code (opens in new tab)

Solution retrospective

What are you most proud of, and what would you do differently next time?

Hi ! I hope my solution is correct. Is the paragraph problematic because there is only two line ? Should I have used a flex box ?

What challenges did you encounter, and how did you overcome them?

/

What specific areas of your project would you like help with?

/

Code

Please log in to post a comment

Log in

Community feedback

  • P
    Daniel 🛸•44,790
    @danielmrz-dev

    Hello, @Demaxs26!

    Your project is looking fantastic!

    I'd like to suggest a way to make it even better:

    • I noticed that your card is not centered, so here's a highly efficient approach to position an element at the center of the page both vertically and horizontally:

    📌 Apply this CSS to the body (avoid using position or margins in order to work correctly):

    body {
    min-height: 100vh;
    display: flex; 
    justify-content: center;
    align-items: center;
}

    I hope you find this helpful!

    Keep up the excellent work!

    Marked as helpful
  • Bryan Li•3,530
    @Zy8712

    Hi there! Congrats on finishing your first challenge!

    Some things I would suggest you to alter/change:

    • instead of using <h2>, you should use the <h1> tag as headings are meant to be used in order from <h1> to <h6> without skips. The headings come with default font sizes that can be changed using the font-size attribute in css
    • to center the white card you can do something like this for the parent container which in this case is your <body> element:
    body{
   display: flex;
   flex-direction: column;
   justify-content: center;
   align-items: center;
   min-height: 100vh;
}

    Hope you find this feedback useful 👍

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord