Ahmed Faisal• 5,095
@afrussel
Posted
Good work. I think you also use a toggle function for animation. And if you want to make your work like the design check my solution
Marked as helpful
1
Submitted
Some clamp() and animations for you! - Article preview - HTML, CSS, JS
Stefano• 155
@StefanoDeCapitani
Design comparison
Solution retrospective
First time using animations and javascript on a Frontend Mentor challenge. I feel like I've also done a good work on responsiveness this time! If you'd like to give me your thoughts about it, it would be great! :)
Community feedback
Mustafa• 415
@Mostafa-T
Posted
Its perfect !! 🔥 there is a little adjustment for a better look which is the box-shadow of the main container could have more blur
Happy coding 👨🏾💻
Marked as helpful
0
Fidel Lim• 2,775
@fidellim
Posted
Great work! That's some nice animation you have for the share button. Just a suggestion maybe if you're interested in doing some update for this challenge is that you can add a "cursor: pointer" to the share button as you hover it. So that the user can notice that it is clickable. Also, on your script file, instead of adding an event listener on the body tag, you can just use "toggle" function. You can remove the the body event listener then replace "activeState.classList.add("visible")" with "activeState.classList.toggle("visible")". So that, whenever a user presses the share button, the popup will just disappear again. I hope this helps :)
Marked as helpful
0
The overall size of your card is MUCH to big when compared to the layout. It looks like you have all the elements to have a good challenge result but your current sizing issue is keeping that from happening
Marked as helpful
0
Stefano• 155
@StefanoDeCapitani
Posted
@palgramming You're right! I spent so much time on other issues that when I had all of that working quite properly I wanted to move on and submit the solution, despite the different sizing. I know, I've been lazy...but now that you have pointed it out, I'm going to fix it ;D
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord