Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Space Tourism

@ashrafess00

Desktop design screenshot for the Space tourism multi-page website coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
3intermediate
View challenge

Design comparison


SolutionDesign

Solution retrospective


thank you for providing figma file for free and i really enjoyed making the website

Community feedback

@zineb-Bou

Posted

Hi Ashraf,

Your solution looks good, I am dropping some notes that may help you even further.

  • Make your logo image aria-hidden: true, letting the image be exposed to the screen reader, it will read the image source path, and don't forget to add alt=" page logo".
  • On the home page, "so you want to travel to space" it's all considered as an <h1>, you can use <span/> to divide the title into two different sections so you will be able to style them differently.
  • the same remarque about other pages, don't use <p > for titles use <h2> instead, and your website should only contain one <h1> tag
  • explore I think it's not meant to be for decoration, it's actually a link that will lead the user to a different page to see more options, so don't make it an <div> it's <a>
  • All of your slide progression controls need to be buttons, not links or divs, as they perform an action on the same page.
  • don't add images without adding any alt to it, it's helpful for all users, imagine there is a problem in image loading, alt would provide a description about the image, even if the user won't be able to see it.

Marked as helpful

0

@ashrafess00

Posted

@zineb-Bou thank you so much, your comment is so helpful and i will edit the project tomorrow considering your notes of course I hope you a great day 😊

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord