Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Space Tourism using React

#react#sass/scss#bootstrap

@NabillaTrisnani

Desktop design screenshot for the Space tourism multi-page website coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
3intermediate
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hey Devs, any feedback are welcome. Thanks for the advice :)

Community feedback

Travolgi 🍕 31,460

@denielden

Posted

Hi Nabilla, great job! Congratulations on completing the challenge.

I had a look at your solution and I have a few suggestions for you:

  • in the mobile the menu does not have the background
  • try add transition to the tab element ;)
  • <BrowserRouter> it should be inserted in the index.js by wrapping the app, like this:
ReactDOM.render(
  <React.StrictMode>
    <BrowserRouter>
      <App />  {/* App or any other component */}
    </BrowserRouter>
  </React.StrictMode>,
  document.getElementById('root')
);

Overall you did well :) Hope this help !

Marked as helpful

0

@NabillaTrisnani

Posted

Hi @denielden. Thank you for your input 😁

1
Travolgi 🍕 31,460

@denielden

Posted

@NabillaTrisnani You are welcome! And don't forget to mark my comment as helpful if helped you :)

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord