Submitted over 4 years agoA solution to the Job listings with filtering challenge
Static Job Listing Using React
@EehabArbash
Solution retrospective
Hello, For this challenge, I may not have solved it pixel to pixel, but I've added some CSS animations to spice things up, please tell me what you think and what I can improve. Thanks.
Code
Please log in to post a comment
Log in with GitHubCommunity feedback
- @yasssuz
Hello!
Awesome build, just a few tips:
- Your App.js in wrapping the entire web app. This can make your code harder to read and to maintain, consider creating components (I strongly suggest doing that with
.filters-bar-list,.jobs-list, andjob-filters). - Having your entire application in one file is causing unnecessary re-renders. A solution to that would be creating components as I said before and isolating them to make them re-render only when necessary (learn about memo, useCallback and useMemo).
- Take a look at your Html issues reported by front-end mentor!
For any question or suggestion feel free to ask :)
Upvote my comment if i was helpfull and happy conding :)
- Your App.js in wrapping the entire web app. This can make your code harder to read and to maintain, consider creating components (I strongly suggest doing that with
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord