Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 8 months ago

Static QR Code Component

P
Lovro Peraić•420
@loki-pepe
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

Even though the project was so small and simple, I am proud of using semantic HTML elements, abandoning my previous habit of using generic div elements coupled with a myriad of classes.

What challenges did you encounter, and how did you overcome them?
  • Image gap: At first the gap between the QR code image and the element below it baffled me, but setting the display property of the image to block solved the issue.
  • Horizontal and vertical centering: I was unsure what the best approach to this problem would be. I knew the desired alignment could be implemented with grid or flexbox, but considering the simple structure of the page I deemed neither of the two layout mechanisms were necessary and I opted for the following solution:
body {
    position: relative;
}

main {
    position: absolute;
    top: 50%;
    left: 50%;
    transform: translate(-50%, -50%);
}
What specific areas of your project would you like help with?
  • Sizing different to design: While the height of the heading content box in the design file was 52px, the height of the same content box in my generated page was 52.81px (using the same font, font size, line height and letter spacing as specified in the design file), which slightly shifted the content below the image. I thought it to be reasonable enough to ignore this difference, but I would like to know if this should be fixed and how.

  • Fixed height and width of main content: as the design file didn't call for dynamic sizing, I set the dimensions of the main element using height: 499px; and width: 320px;, as specified in the design file. Was this the right approach?

Code
Loading...

Please log in to post a comment

Log in with GitHub

Community feedback

  • P
    Prince Awuah Karikari•170
    @PRINCEKK122
    Posted 8 months ago

    Great solution, and the projects looks great on all screen sizes.

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub