Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 6 months ago

Static QR Code UI Component using Semantic HTML and CSS Flexbox

accessibility, pure-css, foundation
P
Ethan John Paguntalan•260
@dev-ethanjohn
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

I got to learn about CSS flexbox and alignment properties. Structuring my HTML although not yet really optimized.

In this project Im using a fixed width based off from the fixed dimension of the card design from Figma. I found adding padding to the parent container is unnecessary with flexbox (center) unless I want to have explicit horizontal padding in smaller devices and the card itself has adaptable width dimension.

What challenges did you encounter, and how did you overcome them?

I am quite unsure about my HTML tags semantically, but looking at some tutorials and the MDN documentation help me figure out some tags I need to use for this project.

What specific areas of your project would you like help with?

If someone does look on this solution, I hope to get any feedback regarding how i structure my HTML and if my classes are descriptive enough or makes sense for styling.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Marcos Travaglini•6,230
    @Blackpachamame
    Posted 6 months ago

    Hey your solution is amazing! 🤩

    I'll leave you with some comments that might help you improve:

    • I don't see any point in placing a <div class="qr-hero"> inside the main when the main itself can already serve as a general container.
    • You can apply display: block to the image to remove the white space generated underneath. Although visually in this case it is irrelevant, it helps you better calculate the space with other elements
    • Use min-height and max-width, this will help the content stretch or shrink if you need to. Unlike height and width which can cause your content to be cut off on certain screens. For example, use min-height: 100vh instead of height: 100vh
    • A good practice for naming your CSS classes is to use the BEM methodology. Although you have done it correctly, you can put it into practice next time.
    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub