Stats Preview Card

Community feedback

• 

  Jason Moody•300

  @MoodyJW

  Posted about 3 years ago

  Hey Michael! You've done a great job on this. Here's some feedback.

  • Your code isn't formatted very well, especially the HTML

  • Generally there isn't much of a need for empty lines in HTML. Sometimes it's useful to break up large files into smaller pieces, but large projects are going to do this using separate files

  • The indentation is also significantly wider than it needs to be. Two spaces seems to be the most frequently used indentation for HTML

  • Your CSS is better, but still has some unneeded empty lines

  • You should remove comments. Doesn't really matter, but it's a good practice to only leave comments that are necessary to explain why some code is there.

  • You've used the .img-container class redundantly inside of the media query

  • The responsiveness to screen sizes doesn't quite work on smaller screens. You might have more luck using a flex box design instead of a grid.

  But the laptop screen is great! Hope this helps you out, keep at it

  01

  Marked as helpful