Frontend Mentor | Stats Preview Card Component coding challenge solution

Community feedback

@vanzasetia

Posted about 2 years ago

Hello, Ana! 👋

Congratulations on finishing this challenge! 🎉

I have some feedback on this solution:

Accessibility
- All the page content should live inside landmark elements (header, main, and footer). By using them correctly, users of assistive technology navigate the website easily. In this case, wrap all of it with main tag,except the attribution. The attribution should be lived inside the footer.

<body>
  <main>
    page content goes here...
  </main>
  <footer class="attribution">
      good job on doing this! 👍
  </footer>
</body>

Use CSS to uppercase the text. The uppercased word in the HTML will be spelled by the screen reader (spelled letter by letter).
For the stats element, swap the section tag with ul and wrap each item with li instead.
The stats number should not be a heading for sure. The content below it is too small. You might find it helpful if you think of a heading like a title in a document.
Use rem or sometimes em unit instead of px. Using px will not allow the users to control the size of the page based on their needs.
Best Practice (Recommended)
- I would recommend writing the styling using the mobile-first approach. It often leads to shorter and better performance code. As a result, mobile users will no longer be required to process all of the desktop styles.