Eray• 1,410
@ErayBarslan
Posted
Hey there, excellent work on this one and good to hear you're having fun :) Some suggestions:
- To overlay, on
.background_img
you can usemix-blend-mode: multiply;
so you'd match with design. - Content overflows between 375-900px. I'd suggest designing mobile version first and instead of a fixed
width
on main you can usemax-width
so that your page would be responsive for all sizes with the same amount of code. By defaultwidth:auto
which fills the available space. By overriding it we take the responsiveness away. - For semantic markup you should use landmark elements to wrap your elements instead of div like :
<main class="container">
&<footer class="attribution">
. Your designs stays the same but page becomes more accesible. Happy coding :)
Marked as helpful
1
Queen• 60
@UmesiQueen
Posted
Hey Eray, Thank you very much for your feedback. I have now implemented your suggestions. It works perfectly.
0