Looking to hire developers?
No real questions, but any tips or thoughts welcomed.
The mobile solution is pretty much identical, but desktop is off a bit. I chose not to try and chase it down through iteration.
@darryncodes
Posted
Hi Robert,
Love the solution, good work.
Two observations at a glance you could consider:
margin: 0 auto; would nicely centre your mobile designGet <span>insights</span> that help your business grow. in a h1 tag for semantics and accessibility reasons.Happy coding!
@tarasis
Posted
@darryncodes Good points, thank you. Wasn't even really thinking about the "Get ..." being a header.
@afrussel
Posted
Use font size in body is a better practice. After body tag use main section article for each area is good for best practice
@tarasis
Posted
@afrussel Thank you for the point about font-size, the reason I put it in html was for using rem units. Per css-tricks article its the place to put it for that.
"that rem unit is relative to the font-size of the <html> element, which is the document root. So, whatever is set as the user-default at the root level is what the .module class will scale to." https://css-tricks.com/html-vs-body-in-css/
@junaiddaud
Posted
Nicely done
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord
