Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 3 years ago

Stats preview card component 🌞 Light-mode / Dark-mode toggle feature

Yazdun•1,310
@Yazdun
A solution to the Stats preview card component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Hello ! I added extra feature to this challenge so you can toggle between dark and light theme. and here I have some questions :

  • Website should load dark theme by default, does it function correctly on your browser ?
  • Can you toggle between themes ? does this solution functions correctly ?
  • What are the best practices on creating dark and light mode ? is my approach any good ?

✅ I'd be glad to know your feedbacks on this

Code
Couldn’t fetch repository

Please log in to post a comment

Log in with GitHub

Community feedback

  • Sara Dunlop•450
    @Risclover
    Posted over 3 years ago

    After you gave me some feedback, I decided to look at your solution for the same challenge and found this. :) So, to help you out because nobody else did:

    Website should load dark theme by default, does it function correctly on your browser ?

    • Yes. I'm using Chrome (v. 95.0.4638.54), if it matters.

    Can you toggle between themes ? does this solution functions correctly ?

    • Yes.

    What are the best practices on creating dark and light mode ? is my approach any good ?

    • If you are asking in terms of code, I couldn't tell you. However, I will say that, in regards to your color scheme for the "Light" mode, it kind of hurts my eyes. Something about the background being darker than the content box (grey vs. white) coupled with the blue accents makes my brain not like it. I think if you were to make the background white and the content box grey, that could work better.

    Edit: Or, after taking a second look at it, maybe if you were to make it so that the shadow goes around the whole box instead of just at the bottom to create some better depth, that might also be a possible way to improve the visuals.

    Thanks again for your comment on my challenge! Yours looks wonderful!

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub