@Risclover
Posted
After you gave me some feedback, I decided to look at your solution for the same challenge and found this. :) So, to help you out because nobody else did:
Website should load dark theme by default, does it function correctly on your browser ?
- Yes. I'm using Chrome (v. 95.0.4638.54), if it matters.
Can you toggle between themes ? does this solution functions correctly ?
- Yes.
What are the best practices on creating dark and light mode ? is my approach any good ?
- If you are asking in terms of code, I couldn't tell you. However, I will say that, in regards to your color scheme for the "Light" mode, it kind of hurts my eyes. Something about the background being darker than the content box (grey vs. white) coupled with the blue accents makes my brain not like it. I think if you were to make the background white and the content box grey, that could work better.
Edit: Or, after taking a second look at it, maybe if you were to make it so that the shadow goes around the whole box instead of just at the bottom to create some better depth, that might also be a possible way to improve the visuals.
Thanks again for your comment on my challenge! Yours looks wonderful!
Marked as helpful
@Yazdun
Posted
@Risclover Thanks for your feedback and Thank God it's functioning correctly I always worry about that š
I didn't realize anything wrong about color scheme until now, now that you mention it I think I get the point and it looks weird to me too, I'll gonna fix it, Thanks for pointing it out I appreciate it š
